Updated:
Description:
In the Linux kernel, the following vulnerability has been resolved: usb: gadget: ncm: Avoid dropping datagrams of properly parsed NTBs It is observed sometimes when tethering is used over NCM with Windows 11 as host, at some instances, the gadget_giveback has one byte appended at the end of a proper NTB. When the NTB is parsed, unwrap call looks for any leftover bytes in SKB provided by u_ether and if there are any pending bytes, it treats them as a separate NTB and parses it. But in case the second NTB (as per unwrap call) is faulty/corrupt, all the datagrams that were parsed properly in the first NTB and saved in rx_list are dropped. Adding a few custom traces showed the following: [002] d..1 7828.532866: dwc3_gadget_giveback: ep1out: req 000000003868811a length 1025/16384 zsI ==> 0 [002] d..1 7828.532867: ncm_unwrap_ntb: K: ncm_unwrap_ntb toprocess: 1025 [002] d..1 7828.532867: ncm_unwrap_ntb: K: ncm_unwrap_ntb nth: 1751999342 [002] d..1 7828.532868: ncm_unwrap_ntb: K: ncm_unwrap_ntb seq: 0xce67 [002] d..1 7828.532868: ncm_unwrap_ntb: K: ncm_unwrap_ntb blk_len: 0x400 [002] d..1 7828.532868: ncm_unwrap_ntb: K: ncm_unwrap_ntb ndp_len: 0x10 [002] d..1 7828.532869: ncm_unwrap_ntb: K: Parsed NTB with 1 frames In this case, the giveback is of 1025 bytes and block length is 1024. The rest 1 byte (which is 0x00) won't be parsed resulting in drop of all datagrams in rx_list. Same is case with packets of size 2048: [002] d..1 7828.557948: dwc3_gadget_giveback: ep1out: req 0000000011dfd96e length 2049/16384 zsI ==> 0 [002] d..1 7828.557949: ncm_unwrap_ntb: K: ncm_unwrap_ntb nth: 1751999342 [002] d..1 7828.557950: ncm_unwrap_ntb: K: ncm_unwrap_ntb blk_len: 0x800 Lecroy shows one byte coming in extra confirming that the byte is coming in from PC: Transfer 2959 - Bytes Transferred(1025) Timestamp((18.524 843 590) - Transaction 8391 - Data(1025 bytes) Timestamp(18.524 843 590) --- Packet 4063861 Data(1024 bytes) Duration(2.117us) Idle(14.700ns) Timestamp(18.524 843 590) --- Packet 4063863 Data(1 byte) Duration(66.160ns) Time(282.000ns) Timestamp(18.524 845 722) According to Windows driver, no ZLP is needed if wBlockLength is non-zero, because the non-zero wBlockLength has already told the function side the size of transfer to be expected. However, there are in-market NCM devices that rely on ZLP as long as the wBlockLength is multiple of wMaxPacketSize. To deal with such devices, it pads an extra 0 at end so the transfer is no longer multiple of wMaxPacketSize.
CVSS3: 7.5
OS | Vendor version | Errata |
---|---|---|
Debian 10 | 4.19.316-1 | DLA-3840-1 |
Debian 10 cloud | 4.19.316-1 | DLA-3840-1 |
Ubuntu 20.04 | 5.4.0-186.206 | USN-6831-1 |
Ubuntu 20.04 AWS | 5.4.0-1126.136 | USN-6831-1 |
Ubuntu 20.04 Azure | 5.4.0-1131.138 | USN-6831-1 |
Debian 11 | 5.10.216-1 | DSA-5681-1 |
Ubuntu 22.04 | 5.15.0-112.122 | USN-6820-1 |
Ubuntu 22.04 AWS | 5.15.0-1063.69 | USN-6821-3 |
Ubuntu 22.04 Azure | 5.15.0-1066.75 | USN-6821-4 |
Ubuntu 20.04 HWE AWS | 5.15.0-1063.69~20.04.1 | USN-6821-3 |
Ubuntu 20.04 GCP | 5.4.0-1130.139 | USN-6831-1 |
OS | Original kernel version | State |
---|---|---|
Debian 10 | |
Planned |
Debian 10 cloud | |
Planned |
Ubuntu 20.04 |
5.4.0-171.189
show all
hide all
5.4.0-172.190
5.4.0-173.191
5.4.0-174.193
5.4.0-176.196
5.4.0-177.197
5.4.0-181.201
5.4.0-182.202
|
Released |
Ubuntu 20.04 AWS |
5.4.0-1118.128
show all
hide all
5.4.0-1119.129
5.4.0-1120.130
5.4.0-1121.131
5.4.0-1122.132
5.4.0-1123.133
5.4.0-1124.134
5.4.0-1125.135
|
Released |
Ubuntu 20.04 Azure |
5.4.0-1123.130
show all
hide all
5.4.0-1124.131
5.4.0-1126.133
5.4.0-1127.134
5.4.0-1128.135
5.4.0-1129.136
5.4.0-1130.137
|
Released |
Debian 11 | |
Planned |
Ubuntu 22.04 |
5.15.0-94.104
show all
hide all
5.15.0-97.107
5.15.0-100.110
5.15.0-101.111
5.15.0-102.112
5.15.0-105.115
5.15.0-106.116
5.15.0-107.117
|
Released |
Ubuntu 22.04 AWS |
5.15.0-1053.58
show all
hide all
5.15.0-1055.60
5.15.0-1056.61
5.15.0-1057.63
5.15.0-1060.66
5.15.0-1061.67
5.15.0-1062.68
|
Released |
Ubuntu 22.04 Azure |
5.15.0-1056.64
show all
hide all
5.15.0-1057.65
5.15.0-1058.66
5.15.0-1059.67
5.15.0-1060.69
5.15.0-1061.70
5.15.0-1063.72
5.15.0-1064.73
|
Released |
Ubuntu 20.04 HWE AWS |
5.15.0-1053.58~20.04.1
show all
hide all
5.15.0-1055.60~20.04.1
5.15.0-1056.61~20.04.1
5.15.0-1057.63~20.04.1
5.15.0-1058.64~20.04.1
5.15.0-1061.67~20.04.1
5.15.0-1062.68~20.04.1
|
Released |
Ubuntu 20.04 HWE Azure |
5.15.0-1056.64~20.04.1
show all
hide all
5.15.0-1057.65~20.04.1
5.15.0-1058.66~20.04.2
5.15.0-1059.67~20.04.1
5.15.0-1060.69~20.04.1
5.15.0-1061.70~20.04.1
5.15.0-1063.72~20.04.1
5.15.0-1064.73~20.04.1
|
Released |
Ubuntu 20.04 GCP |
5.4.0-1122.131
show all
hide all
5.4.0-1123.132
5.4.0-1124.133
5.4.0-1125.134
5.4.0-1126.135
5.4.0-1127.136
5.4.0-1128.137
5.4.0-1129.138
|
Released |